-
-
Notifications
You must be signed in to change notification settings - Fork 55
(#70) Implemented Swarm.init() #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Job #75 is now in scope, role is |
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale Looks nice, just a question.
And, as a note, please break your tasks better. It seems to me this clearly took you more than 30min (including documentation reading and so on).
Even if you wanted to work that much, it's not ok for the project's image to accept work in more value than it pays. Well, it is not the case in this project, since there are no money involved, but you get the idea :D
} | ||
|
||
@Override | ||
public String init(final String listenAddress) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale Why return String
here and bellow? Isn't the response a Json object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rultor try to merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
This surprised me because I found this one of the quickest ones I think. But fine... I will literally time myself next time. |
@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 20s)
|
The job #75 is now out of scope |
This PR:
Swarm
methods