Skip to content

Conversation

llorllale
Copy link
Contributor

@llorllale llorllale commented Apr 12, 2018

This PR:

Note: I'm not sure if it's worth overloading restart() with a timeout parameter (see the linked docs)

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2018

Job #80 is now in scope, role is REV

@coveralls
Copy link

Pull Request Test Coverage Report for Build 125

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 78.873%

Totals Coverage Status
Change from base Build 124: 1.2%
Covered Lines: 168
Relevant Lines: 213

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 125

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 78.873%

Totals Coverage Status
Change from base Build 124: 1.2%
Covered Lines: 168
Relevant Lines: 213

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2018

@amihaiemil/z everybody who has role REV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@amihaiemil amihaiemil self-assigned this Apr 12, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 12, 2018

This pull request #80 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @amihaiemil/z

Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale looks nice, just one comment

* @throws UnexpectedResponseException If the status response is not
* expected.
*/
void restart() throws IOException, UnexpectedResponseException;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale UnexpectedResponseException is runtime exception, no need to declare it :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil checkstyle fails if we don't include it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale strange, I don't remember checkstyle being that strict. Do you know how to add an exception for it quickly, or should we merge and I'll look into it later?

Copy link
Contributor Author

@llorllale llorllale Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil to be clear, checkstyle fails when I add the @throws tag without declaring the exception. What you want is to include @throws without declaring the exception in throws, correct?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale you're right, let's leave it this way then.

@0crat
Copy link
Collaborator

0crat commented Apr 17, 2018

@amihaiemil/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Apr 17, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Apr 17, 2018

@rultor merge it

@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 22s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 7721
+ echo '1.67.2 b60448e97'
1.67.2 b60448e97
+ date
Tue Apr 17 20:40:32 CEST 2018
+ uptime
 20:40:32 up 24 days, 13 min,  0 users,  load average: 1.10, 0.62, 0.31
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
./run.sh: line 23: syntax error near unexpected token `('
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit 378f231 into amihaiemil:master Apr 17, 2018
@llorllale llorllale deleted the 76 branch April 17, 2018 18:52
@0crat
Copy link
Collaborator

0crat commented Apr 17, 2018

Order was finished: +15 point(s) just awarded to @amihaiemil/z

@0crat
Copy link
Collaborator

0crat commented Apr 17, 2018

The job #80 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants