Convert OgAccess into a service #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +48,16 @@ class OgAccessTestBase extends UnitTestCase { | |||
| */ | |||
| protected $groupManager; | |||
|
|
|||
| /** | |||
| * The OgAccess class, this is the system under test. | |||
There was a problem hiding this comment.
what do you mean by this is the system under test.?
There was a problem hiding this comment.
Oh that is the formal name in unit testing for the class that is being tested, it's called the "SUT" or System Under Test.
It's not yet common in the Drupalverse, I'll make it clearer.
There was a problem hiding this comment.
no worries, if it's PHP standard we can use it.
|
Hopefully this is a bit clearer. The cacheability stuff is one of the hardest parts in Drupal 8 for me. |
…m the OG settings config object during access checks.
|
Thanks. |
amitaibu
added a commit
that referenced
this pull request
Dec 14, 2016
OgMembership static cache are not cleared on membership save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
OgAccessconsists of a collection of static methods. When we initially started the D8 port it made sense to use static methods so we could iterate rapidly, but currently this is starting to impede progress.This PR converts
OgAccessinto a proper service that uses the dependency injection container for its dependencies, so it can be properly mocked in unit tests.