Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker, bug fixes, and more #12

Merged
merged 26 commits into from
Mar 18, 2023
Merged

Docker, bug fixes, and more #12

merged 26 commits into from
Mar 18, 2023

Conversation

amnuts
Copy link
Owner

@amnuts amnuts commented Feb 14, 2023

This adds a docker container setup that you can use if you want, but you by no means have to.

The binaries have had their names changes to amnutsTalker and amnutsIdent (rather than have the version on the binary) and get moved to the build folder when you do make install.

All of the data files (help docs, picture files, user-related files) have been moved to a sub-folder called files in order to keep top-level structure a bit cleaner and maybe eventually lead to different mounting options in docker.

Some bug fixes and a seg-fault have been fixed.

And the README has been updated for the first time in 20 years! 🙌

src/includes/defines.h Outdated Show resolved Hide resolved
README Outdated Show resolved Hide resolved
Bug reports I'm still up to receiving, but even then, don't be upset if
you don't get a thorough response.


Andrew Collington
The Amnuts Development Team
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, the development team has been removed and we jumped ahead a few decades

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do anything about the march of time - it really has been a couple decades since that was last updated! But it wasn't cool for me to remove the dev team line, so that'll go back in once I'm in front of my computer again!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a7ce2cf

@@ -17,6 +17,6 @@ the talker (instead of readin' this generic thing!)
To find out what all the changes are it's best to talk to your admins and
ask them all that has changed by telling them to look in the amnuts_changes
file that came with Amnuts. Of course, you could also check out the
Amnuts website at: ~OL~FChttp://amnuts.talker.com/~RS if you want!
Amnuts website at: ~OL~FChttps://www.amnuts.net/~RS if you want!
Copy link

@Uzume Uzume Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to know amnuts.net still works (although it seems to just be a redirect) and even better seems to now support https encryption but I notice you did not change everything to point the the https. I also noticed the redirector does not seem to care if the URL has the leading "www." or not.
There are many http://www.amnuts.net/ about vs. https://www.amnuts.net/
It seems to me, if you intend to keep the amnuts.net redirector around, all the references should be changed to the same thing.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's just a redirect to GitHub. One day I might do a website again - might even dig deep into the harddrives and see if I can resurrect the Amnuts site from the late '90s 😁

All forms of amnuts.net should redirect, though, be it with or without www, http or https. Seems to work for me, but I'll make sure.

However, I can adjust all the instances in the code to be consistent if they're not.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a7ce2cf

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some of the old site designs, btw 😁 #13

@amnuts amnuts merged commit 8f1de57 into main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants