Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/170 block bound tx to prevent replay attack #173

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Feature/170 block bound tx to prevent replay attack #173

merged 7 commits into from
Dec 3, 2019

Conversation

h0n9
Copy link
Contributor

@h0n9 h0n9 commented Nov 28, 2019

  • Implement 'BindingBlockManager'
  • Implement 'ReplayPreventer'
  • Integrate newly added features to 'AMO' app with test codes

resolves #170

@h0n9
Implement 'BindingBlockManager'
a2b981a 
- add corresponding test codes
- add 'LastHeight' to 'TxBase', 'TxSign' structure
- implant 'BindingBlockManager' in 'AMOApp'
@h0n9
Implement 'ReplayPreventer'
d93c116 
- add corresponding test codes
- implant 'ReplayPreventer' to 'AMOApp'
@h0n9
Add 'AMOApp' related 'BlockBinding' test codes
f93f38b 
- implant 'BlockBindingManager' to 'DeliverTx()'
@h0n9
Integrate newly added features with test codes
ac1dcba 
- 'BlockBindingManager' gets integrated to 'AMO' app
- 'ReplayPreventer' gets integrated to 'AMO' app
- update corresponding test codes
@h0n9
Handle tx differently depending on recheck
b4948a4
@h0n9 h0n9 added the feature New feature or request label Nov 28, 2019
@h0n9 h0n9 requested a review from Lbird November 28, 2019 02:45
@h0n9 h0n9 self-assigned this Nov 28, 2019
@h0n9 h0n9 added this to the v1.3 milestone Nov 28, 2019
Lbird
Lbird suggested changes Dec 3, 2019
View reviewed changes
amo/blockchain/replay_preventer.go Outdated Show resolved Hide resolved
amo/store/tx_indexer.go Outdated Show resolved Hide resolved
amo/store/tx_indexer.go Outdated Show resolved Hide resolved
@h0n9
Resolve requested changes
dbed815 
- resolve ambiguity of function names
@h0n9 h0n9 merged commit 7009993 into master Dec 3, 2019
@h0n9 h0n9 deleted the feature/170_block-bound_tx_to_prevent_replay_attack branch December 3, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lbird Lbird Lbird requested changes

Assignees

@h0n9 h0n9

Labels
feature New feature or request
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Block-bound tx to prevent replay attack
2 participants
@h0n9 @Lbird