Rebase Orchestrator #150
Merged
Rebase Orchestrator #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2020 16:38
aalavandhan
reviewed
Apr 9, 2020
|
Overall idea looks good, Do you prefer if we review it more thoroughly and
make it ready or wait until we hear back from Uniswap?
…On Thu, Apr 9, 2020 at 11:43 AM Nithin Krishna ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In contracts/UFragmentsPolicy.sol
<#150 (comment)>:
> @@ -44,6 +44,8 @@ contract UFragmentsPolicy is Ownable {
// (eg) An oracle value of 1.5e18 it would mean 1 Ample is trading for $1.50.
IOracle public marketOracle;
+ address public orchestrator = address(0x0);
to make it upgrade safe; we might have to move this to the bottom
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#150 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOQ5IRR5F57CYC3SN7C6XTRLYJOHANCNFSM4MDQEL2A>
.
--
Cheers,
Ahmed
|
ahnaguib
reviewed
Apr 17, 2020
aalavandhan
reviewed
Apr 20, 2020
aalavandhan
reviewed
Apr 20, 2020
aalavandhan
reviewed
Apr 20, 2020
|
Looks good, a few minor comments 👍 |
aalavandhan
reviewed
Apr 20, 2020
ahnaguib
approved these changes
Apr 20, 2020
added 2 commits
April 20, 2020 14:26
aalavandhan
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.