Remove price history and add rebaseLag parameter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandoniles
reviewed
Jun 13, 2018
contracts/UFragmentsPolicy.sol
Outdated
| int256 smoothedSupplyDelta = calcSmoothedSupplyDelta(); | ||
| uFrags.rebase(smoothedSupplyDelta); | ||
| emit Rebase(epoch, smoothedSupplyDelta); | ||
| int256 supplyAdjustment = calcSupplyAdjustment(supplyDelta); |
There was a problem hiding this comment.
The names supplyDelta and supplyAdjustment are a little confusing next to each other. Maybe we can find better names.
supplyDelta -> The adjustment we'd make in a perfectly efficient market....
maxSupplyDelta?
theoreticalSupplyDelta?
perfectMarketSupplyDelta?
supplyAdjustment -> The actual delta we've decided to apply.
actualSupplyDelta?
adjustedSupplyDelta?
laggedSupplyDelta?
(Also update the terminology in the calcSupplyAdjustment function)
contracts/UFragmentsPolicy.sol
Outdated
| } | ||
|
|
||
| /** | ||
| * @notice Allows setting of the rebase lag parameter which controls the amount of supply |
There was a problem hiding this comment.
How about this?
The rebase lag parameter controls how long it takes, in cycles, to apply the effects of a rebase operation.
If the lag equals the smallest value of 1, it means we apply the full supply correction needed to completely
react to the existing exchange rate each rebase cycle. If it is a high number like 100, it means we only
apply 1/100th of the theoretical correction.
The purpose of this parameter is to avoid overreacting to current market conditions, and also to avoid
outpacing how fast the markets can react to the policy changes that are made.
Whatever you end up with, also update the contract parameter comment.
|
@brandoniles this is ready as well! Let me know if it looks good. |
brandoniles
approved these changes
Jun 14, 2018
contracts/UFragmentsPolicy.sol
Outdated
| * rates up until now. | ||
| * @return Damps the supply delta value so that only small changes to supply are made. | ||
| * This is currently set to supplyDelta / rebaseLag. | ||
| * |
aalavandhan
added a commit
that referenced
this pull request
Jun 12, 2019
* implemented rebase window * code review fixes: * changes round #2 * fixed incorrect test spec message * added minRebaseTimeIntervalSec_>0 check back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.