Skip to content

Policy interface update #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2024
Merged

Policy interface update #287

merged 3 commits into from
Oct 16, 2024

Conversation

aalavandhan
Copy link
Member

Added cpi and exchange rate getters

@aalavandhan aalavandhan force-pushed the policy-interface-update branch from 3275adb to fe4a8c6 Compare October 9, 2024 18:31
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 9, 2024 •
edited
Loading

Policy interface update

Generated at commit: e3931381cff3948a708dbf6166ac37331ed2e610

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
5
23
30
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

brandoniles
brandoniles reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add getTargetRate() to the IAmpleforth interface.

But don't think we need getExchangeRate()

brandoniles
brandoniles approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalavandhan aalavandhan merged commit d2b6727 into master Oct 16, 2024
3 checks passed
@aalavandhan aalavandhan deleted the policy-interface-update branch October 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandoniles brandoniles brandoniles approved these changes

@nms-7 nms-7 nms-7 approved these changes

@ahnaguib ahnaguib Awaiting requested review from ahnaguib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalavandhan @brandoniles @nms-7