Updated invalid oracle input handling #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated invalid oracle input handling
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
brandoniles
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
I suppose there is a case where the oracle report becomes valid later inside the same rebase window. In that case, an otherwise successful non-zero rebase would be blocked by the zero rebase that came before it.
But I don't see any good way to guard against that and still get this functionality.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rebase with zero supply change when oracle inputs are invalid at the time of rebase