support groupIdentify calls #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damahua
reviewed
Oct 3, 2018
| var baseSetToString = !_defineProperty ? identity_1 : function(func, string) { | ||
| return _defineProperty(func, 'toString', { | ||
| var baseSetToString = !_defineProperty$1 ? identity_1 : function(func, string) { | ||
| return _defineProperty$1(func, 'toString', { |
damahua
reviewed
Oct 3, 2018
| groups[groupType] = groupName; | ||
| var identify = new Identify().set(groupType, groupName); | ||
| this._logEvent(constants.IDENTIFY_EVENT, null, null, identify.userPropertiesOperations, groups, null, null); | ||
| this._logEvent(constants.IDENTIFY_EVENT, null, null, identify.userPropertiesOperations, groups, null, null, null); |
There was a problem hiding this comment.
do we need a GROUP_IDENTIFY_EVENT? and groupPropertiesOpeations?
damahua
reviewed
Oct 3, 2018
| if (identify_obj instanceof Identify) { | ||
| // only send if there are operations | ||
| if (Object.keys(identify_obj.userPropertiesOperations).length > 0) { | ||
| return this._logEvent(constants.GROUP_IDENTIFY_EVENT, null, null, null, _defineProperty({}, group_type, group_name), identify_obj.userPropertiesOperations, null, opt_callback); |
There was a problem hiding this comment.
it seems we have the GROUP_IDENTIFY_EVENT, do we need groupPropertiesOpeations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for group identify calls. We can reuse
identify.jsobjects to capture the operations. Generates an event that is very similar to$identifyevents. Currently enforcing only 1group_namevalue pergroupIdentify