Fix bug preventing logLevel from being set to DISABLE #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazzy
changed the title
uap-dev
reviewed
Dec 5, 2018
test/utils.js
Outdated
|
|
||
| it('can set log level to DISABLE', function() { | ||
| utils.setLogLevel('DISABLE'); | ||
| assert.strictEqual(utils.getLogLevel(), 0); |
There was a problem hiding this comment.
Thanks updated.
This API is kind of dumb. setLogLevel takes a string and getLogLevel returns this enumerated value. :-/
uap-dev
approved these changes
Dec 5, 2018
blazzy
force-pushed
the
fix-disable-log-level
branch
from
699ae43 to
b303de7
Compare
blazzy
force-pushed
the
fix-disable-log-level
branch
from
b303de7 to
972add4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.