Drop dependency on top-domain and rollup-plugin-node-builtins and update some dated deps #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djih
approved these changes
Dec 10, 2018
| const domain = levels[i]; | ||
| const opts = { domain: '.' + domain }; | ||
|
|
||
| baseCookie.set(cname, 1, opts); |
There was a problem hiding this comment.
my only gripe is that this function seems to be a getter method but it's also setting things into the cookie
There was a problem hiding this comment.
Yeah. It's ugly. It does clean up after itself though.
There might be a better way of doing this, but I don't want to stray too far from what top-domain's approach without having time to set up proper tests.
| remove('amplitude_test'); | ||
| _options.domain = domain; | ||
|
|
||
| return _options; |
There was a problem hiding this comment.
who uses this return value? we weren't returning it before
| @@ -0,0 +1,5 @@ | |||
| const getLocation = () => { | |||
There was a problem hiding this comment.
super minor: you could probably put this in the utils file instead of making a new module for it
…ate some dated deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.