Skip to content

Conversation

djih
Copy link
Member

@djih djih commented Apr 14, 2016

Cookiestorage has a little test to see if cookies are enabled in browser. The navigator.cookiesEnabled property yields false positives in IE, so we need to test directly by saving a value to cookie, fetching it, and verifying that the value matches.

Before we were using the current time as the test key/value. The problem with using a different key each time is that in rare cases the cookie.delete fails, and so whenever that user reloads the page, they accumulate a bunch of non-repeating cookie values, until their cookie hits max size.

The simple solution is just to use a constant key, with a changing value. If the delete fails, the next test will just overwrite the existing value, instead of creating new entries.

@paladin8
Copy link
Contributor

lgtm

@djih djih merged commit 96d7add into master Apr 14, 2016
@djih djih deleted the fix_cookie_test branch April 14, 2016 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants