fix cookie test key #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookiestorage has a little test to see if cookies are enabled in browser. The navigator.cookiesEnabled property yields false positives in IE, so we need to test directly by saving a value to cookie, fetching it, and verifying that the value matches.
Before we were using the current time as the test key/value. The problem with using a different key each time is that in rare cases the cookie.delete fails, and so whenever that user reloads the page, they accumulate a bunch of non-repeating cookie values, until their cookie hits max size.
The simple solution is just to use a constant key, with a changing value. If the delete fails, the next test will just overwrite the existing value, instead of creating new entries.