fix: add nonce #183
Merged
fix: add nonce #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a nonce to dynamically loaded script tags to improve Content Security Policy (CSP) compliance.
- Adds logic in asyncLoadScript to extract and apply a nonce from an existing element in the DOM.
- Updates the messenger.ts file to include nonce handling for scripts.
Comment on lines
+56
to
+62
| scriptElement.setAttribute( | ||
| 'nonce', | ||
| nonceElem['nonce'] || | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| (nonceElem as any).nonce || | ||
| nonceElem.getAttribute('nonce'), | ||
| ); |
There was a problem hiding this comment.
[nitpick] Consider extracting nonce retrieval into a single variable (e.g., const nonce = nonceElem.getAttribute('nonce') || (nonceElem as any).nonce;) to reduce repetition and improve clarity in the nonce assignment process.
Suggested change
| scriptElement.setAttribute( | |
| 'nonce', | |
| nonceElem['nonce'] || | |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |
| (nonceElem as any).nonce || | |
| nonceElem.getAttribute('nonce'), | |
| ); | |
| const nonce = | |
| nonceElem['nonce'] || | |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |
| (nonceElem as any).nonce || | |
| nonceElem.getAttribute('nonce'); | |
| scriptElement.setAttribute('nonce', nonce); |
Copilot uses AI. Check for mistakes.
|
✅ No documentation updates required. |
tyiuhc
approved these changes
May 9, 2025
bgiori
approved these changes
May 11, 2025
ansonchen2
pushed a commit
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add nonce to new script tags for CSP.
Checklist