Prevent store_validation_errors from clobbering global post when empty invalid_url_post supplied #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y invalid_url_post supplied
amedina
reviewed
Sep 14, 2018
| @@ -360,9 +360,11 @@ public static function get_url_from_post( $post ) { | |||
| public static function store_validation_errors( $validation_errors, $url, $args = array() ) { | |||
There was a problem hiding this comment.
Not for now but may consider splitting this function? Kind of long.
amedina
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix for regression introduced #1426. See also #1428.
When creating a post in Gutenberg and publishing, and then making a change to then update, at that point the invalid URL post replaces the post you're editing.
The issue is that I switched from a boolean check here https://github.com/Automattic/amp-wp/pull/1426/files#diff-57518db0811ee918fee17d27459ed4ecL358:
So switching back to an
empty()check fixes the problem.