Expose and store queried object for validated URL; show edit link #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
add/invalid-url-edit-link
branch
from
97dfd89
to
3a4d574
Compare
* Update HTML comment in valudation response to be AMP_VALIDATION with results as array item. * Include queried_object as another item in the AMP_VALIDATION, with type and id. * Add type-specific edit links to the AMP invalid URL screen's status metabox, if user has capability to edit.
westonruter
force-pushed
the
add/invalid-url-edit-link
branch
from
3a4d574
to
93cb6ed
Compare
westonruter
changed the title
kienstra
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good.
Thanks a lot for storing the queried object. This will also help with displaying the title at the top of this screen.
| <div class="misc-pub-section"> | ||
| <?php | ||
| $view_label = __( 'View URL', 'amp' ); | ||
| $queried_object = get_post_meta( $post->ID, '_amp_queried_object', true ); |
There was a problem hiding this comment.
Great idea to store the queried object. This will also help with displaying the title, like on this design:
| $view_label = $post_type_object->labels->view_item; | ||
| } elseif ( 'term' === $queried_object['type'] && get_term( $queried_object['id'] ) && taxonomy_exists( get_term( $queried_object['id'] )->taxonomy ) ) { | ||
| $taxonomy_object = get_taxonomy( get_term( $queried_object['id'] )->taxonomy ); | ||
| edit_term_link( $taxonomy_object->labels->edit_item, '', $after, get_term( $queried_object['id'] ) ); |
westonruter
commented
Sep 14, 2018
| $validity['url'], | ||
| array_merge( | ||
| array( | ||
| 'invalid_url_post' => $post, |
There was a problem hiding this comment.
This was bad. Fixed in #1428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the following part of the design from #1365: