Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experiments before Percy build #12110

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Enable experiments before Percy build #12110

merged 2 commits into from
Nov 20, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Nov 17, 2017

This PR allows the selective enabling of AMP experiments before snapshotting a page. It also fixes a bug where we weren't cleaning up the cookies that might be set by a given test page.

Fixes #11804
Fixes #11854

@rsimha rsimha self-assigned this Nov 17, 2017
@rsimha rsimha requested a review from newmuis November 17, 2017 22:05
@rsimha
Copy link
Contributor Author

rsimha commented Nov 17, 2017

@newmuis I think this should unblock your visual test PR. Could you let me know if this works for you?

Edit: I tested this myself, and noticed that the experiments are now enabled. Next step is to fix the JS error in the amp-story test. Meanwhile, this PR can be merged.

@rsimha
Copy link
Contributor Author

rsimha commented Nov 20, 2017

@erwinmombay @newmuis Ping.

@rsimha
Copy link
Contributor Author

rsimha commented Nov 20, 2017

/to @jridgewell

@rsimha rsimha merged commit dd7396d into ampproject:master Nov 20, 2017
@rsimha rsimha deleted the 2017-11-16-Cookies branch November 20, 2017 18:06
ghost pushed a commit that referenced this pull request Dec 6, 2017
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants