-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add amp-wordpress-embed component #24952
✨ Add amp-wordpress-embed component #24952
Conversation
Hey @ampproject/wg-caching, these files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation changes look good, just need current year in licenses
@@ -0,0 +1,2 @@ | |||
- westonruter | |||
- amedina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the JSON format for all new OWNERS files. This will become:
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example
{
rules: [
{
owners: [
{ name: "westonruter" },
{ name: "amedina" }
]
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, /cc @kristoferbaxter in case he thinks we should add ampproject/wg-ui-and-a11y
as an owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving OWNERS
changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation changes look good
Is this PR ready to go in? |
No, still on our radar to finish. Most likely to be picked up toward end of Q3. |
) |
@westonruter is this PR still active? |
No. Now that Bento is underway, it'll need to be rewritten to make use of the new APIs anyway. |
Previously #18412.
Fixes #18378.
To test the component in the WordPress plugin, use the branch in this PR: ampproject/amp-wp#3465
Todo
link
message.placeholder
.fallback
is supported. It should be ablockquote
.overflow
so that when the resize is rejected, we can show a button.placeholder
works.listenFor
may not be right.secret
?