♻️ Change amp-story-interactive version to 0.1 #30080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet! These files were changed: Hey @newmuis, @Enriqe! These files were changed: |
gmajoulet
approved these changes
Sep 1, 2020
|
Actually, I can't find where you changed this line in this PR https://github.com/ampproject/amphtml/blob/master/extensions/amp-story-interactive/validator-amp-story-interactive.protoascii#L22 Do you have a validation success test somewhere? I think we can't get to a valid story with the current configuration? |
kristoferbaxter
approved these changes
Sep 1, 2020
|
@gmajoulet Is there a test for the protoascii configuration? |
|
I can only see tests for invalid stories, we should also add one valid story. Matias, could you add it? Thanks! |
|
Added test that passes, and contains one of each component |
honeybadgerdontcare
requested changes
Sep 1, 2020
extensions/amp-story-interactive/0.1/test/validator-amp-story-interactive-valid.html
Show resolved
Hide resolved
extensions/amp-story-interactive/0.1/test/validator-amp-story-interactive-valid.out
Outdated
Show resolved
Hide resolved
gmajoulet
approved these changes
Sep 1, 2020
honeybadgerdontcare
approved these changes
Sep 1, 2020
|
@rsimha for presubmit-checks.js owners approval |
jridgewell
changed the title
jridgewell
approved these changes
Sep 1, 2020
rsimha
approved these changes
Sep 1, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Changed to 0.1 * Missing "interactive" * Changed validator to approve 0.1 * Removed new example * Added valid validation test * Updated comments and descriptions * Added extra comments * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The components should be in 0.1 instead of 1.0