video-manager-impl: remove usage of getIntersectionChangeEntry #31942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
commented
Jan 13, 2021
samouri
force-pushed
the
video-manager-intersection
branch
from
20e1568
to
b82e9ee
Compare
samouri
force-pushed
the
video-manager-intersection
branch
from
262ef76
to
b1b4a1e
Compare
7 tasks
samouri
force-pushed
the
video-manager-intersection
branch
from
b1b4a1e
to
bab9594
Compare
dvoytenko
approved these changes
Jan 19, 2021
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Jan 25, 2021
…oject#31942) * video-manager-impl: remove usage of getIntersectionChangeEntry * revert intersection.js
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
…oject#31942) * video-manager-impl: remove usage of getIntersectionChangeEntry * revert intersection.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Partial for #31540
scrollIntoIfNotVisible_selectBestCenteredInPortrait_Note: besides for the ads initialIntersection experiment, this is the last usage of
getIntersectionChangeEntry