Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup fie-resources experiment #32226

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Cleanup fie-resources experiment #32226

merged 1 commit into from
Jan 29, 2021

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@amp-owners-bot
Copy link

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

powerivq
powerivq approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@powerivq powerivq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume we are ready for full launch?

@dvoytenko
Copy link
Contributor Author

Assume we are ready for full launch?

Let me know what you think. But it's been at 100% for some time (which makes it 50/50 in the current setup).

@dvoytenko dvoytenko merged commit 4b96724 into ampproject:master Jan 29, 2021
@dvoytenko dvoytenko deleted the run3/fie-resources-cleanup branch January 29, 2021 20:56
westonruter added a commit to westonruter/amphtml that referenced this pull request Jan 29, 2021
@westonruter
Merge branch 'master' of github.com:ampproject/amphtml into patch-5
d925a07 
* 'master' of github.com:ampproject/amphtml: (1020 commits)
  🏗 Clean up CI config files (ampproject#32303)
  🏗 Remove Browser Installation from CI tasks and use smaller instances when possible (ampproject#32310)
  Cleanup fie-resources experiment (ampproject#32226)
  🏗  Fix bug in build target discovery logic (ampproject#32307)
  📖 Update TOC on TESTING.md (ampproject#32304)
  🏗 Reorganize browserify caching code (ampproject#32297)
  Fix <textarea> scrollHeight calculation (ampproject#32292)
  📖  Update testing docs (ampproject#32298)
  Fix missing space and mention `https` (ampproject#32293)
  ✨  [Story auto-analytics] Added validation and tests (ampproject#32288)
  🏗  Consolidate remaining CircleCI VM setup steps into separate scripts (ampproject#32290)
  🏗  Cache Karma's babel transforms during CircleCI builds (ampproject#32295)
  Add validation rules for aspect-ratio support via SSR (ampproject#32262)
  bump up viewer-messaging version (ampproject#32286)
  🖍🚀 Alternate `position: fixed/absolute` when docking/undocking (ampproject#32243)
  ✨ [Panning media] Transition siblings by ID (ampproject#32217)
  📦 Update dependency watchify to v4 (ampproject#32284)
  📦 Update dependency rollup to v2.38.1 (ampproject#32274)
  🐛♻️ ADS: XHRs race condtion and responsivnes fix (ampproject#32271)
  Add support for gdpr_conseented_providers, useCCPA_USPAPI, and _fw_us_privacy (ampproject#32275)
  ...
zaparent pushed a commit to zaparent/amphtml that referenced this pull request Feb 1, 2021
@zaparent
Cleanup fie-resources experiment (ampproject#32226)
c0ae1d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

@lannka lannka Awaiting requested review from lannka

@calebcordry calebcordry Awaiting requested review from calebcordry

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @powerivq @ampprojectbot