-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Remove Browser Installation from CI tasks and use smaller instances when possible #32310
Conversation
Hey @rsimha! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This will shave off 20-30 seconds from all the jobs that don't need Chrome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another approval for the large
-> medium
optimization. Nice savings!
* 'master' of github.com:ampproject/amphtml: (1020 commits) 🏗 Clean up CI config files (ampproject#32303) 🏗 Remove Browser Installation from CI tasks and use smaller instances when possible (ampproject#32310) Cleanup fie-resources experiment (ampproject#32226) 🏗 Fix bug in build target discovery logic (ampproject#32307) 📖 Update TOC on TESTING.md (ampproject#32304) 🏗 Reorganize browserify caching code (ampproject#32297) Fix <textarea> scrollHeight calculation (ampproject#32292) 📖 Update testing docs (ampproject#32298) Fix missing space and mention `https` (ampproject#32293) ✨ [Story auto-analytics] Added validation and tests (ampproject#32288) 🏗 Consolidate remaining CircleCI VM setup steps into separate scripts (ampproject#32290) 🏗 Cache Karma's babel transforms during CircleCI builds (ampproject#32295) Add validation rules for aspect-ratio support via SSR (ampproject#32262) bump up viewer-messaging version (ampproject#32286) 🖍🚀 Alternate `position: fixed/absolute` when docking/undocking (ampproject#32243) ✨ [Panning media] Transition siblings by ID (ampproject#32217) 📦 Update dependency watchify to v4 (ampproject#32284) 📦 Update dependency rollup to v2.38.1 (ampproject#32274) 🐛♻️ ADS: XHRs race condtion and responsivnes fix (ampproject#32271) Add support for gdpr_conseented_providers, useCCPA_USPAPI, and _fw_us_privacy (ampproject#32275) ...
… when possible (ampproject#32310) * remove browser installation from several phases * Use less powerful instances for time insentive jobs
Experiment but worth considering.