Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Consolidate CircleCI VM setup steps into separate scripts #32290

Merged
merged 1 commit into from
Jan 29, 2021
Merged

🏗 Consolidate CircleCI VM setup steps into separate scripts #32290

merged 1 commit into from
Jan 29, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 28, 2021 •
edited

PR Highlights:

  • Move all cloud storage setup into .circleci/setup_storage.sh
  • Move all node / dependency installation into .circleci/install_dependencies.sh
  • Log coloring for readability

@rsimha rsimha self-assigned this Jan 28, 2021
@rsimha rsimha changed the title 🏗 Consolidate remaining CircleCI VM setup steps into separate scripts 🏗 Consolidate CircleCI VM setup steps into separate scripts Jan 29, 2021
@rsimha rsimha requested a review from samouri January 29, 2021 05:42
samouri
samouri approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 🟢 🟢 🟢 🟢 🟢
🔴 🔴 🔴 🔴 🔴 🔴

@rsimha rsimha merged commit 71469e7 into ampproject:master Jan 29, 2021
@rsimha rsimha deleted the 2021-01-28-CircleCISteps branch January 29, 2021 05:59
zaparent pushed a commit to zaparent/amphtml that referenced this pull request Jan 29, 2021
@rsimha @zaparent
🏗 Consolidate remaining CircleCI VM setup steps into separate scripts (…
564ed61 
…ampproject#32290)
westonruter added a commit to westonruter/amphtml that referenced this pull request Jan 29, 2021
@westonruter
Merge branch 'master' of github.com:ampproject/amphtml into patch-5
d925a07 
* 'master' of github.com:ampproject/amphtml: (1020 commits)
  🏗 Clean up CI config files (ampproject#32303)
  🏗 Remove Browser Installation from CI tasks and use smaller instances when possible (ampproject#32310)
  Cleanup fie-resources experiment (ampproject#32226)
  🏗  Fix bug in build target discovery logic (ampproject#32307)
  📖 Update TOC on TESTING.md (ampproject#32304)
  🏗 Reorganize browserify caching code (ampproject#32297)
  Fix <textarea> scrollHeight calculation (ampproject#32292)
  📖  Update testing docs (ampproject#32298)
  Fix missing space and mention `https` (ampproject#32293)
  ✨  [Story auto-analytics] Added validation and tests (ampproject#32288)
  🏗  Consolidate remaining CircleCI VM setup steps into separate scripts (ampproject#32290)
  🏗  Cache Karma's babel transforms during CircleCI builds (ampproject#32295)
  Add validation rules for aspect-ratio support via SSR (ampproject#32262)
  bump up viewer-messaging version (ampproject#32286)
  🖍🚀 Alternate `position: fixed/absolute` when docking/undocking (ampproject#32243)
  ✨ [Panning media] Transition siblings by ID (ampproject#32217)
  📦 Update dependency watchify to v4 (ampproject#32284)
  📦 Update dependency rollup to v2.38.1 (ampproject#32274)
  🐛♻️ ADS: XHRs race condtion and responsivnes fix (ampproject#32271)
  Add support for gdpr_conseented_providers, useCCPA_USPAPI, and _fw_us_privacy (ampproject#32275)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @samouri @ampprojectbot