🖍🚀 Alternate position: fixed/absolute when docking/undocking
#32243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Jan 27, 2021
|
|
||
| // If the component's box is way out of view, the runtime might have | ||
| // discarded its size values. | ||
| if (!isSizedRect(inlineRect)) { |
There was a problem hiding this comment.
FYI, you can now use ResizeObserver. Dima created a really nice helper
amphtml/src/utils/size-observer.js
Lines 32 to 36 in 8887dff
There was a problem hiding this comment.
Thanks, I'll give that a try later. We might not need this check after all now since all rects come directly from browser.
samouri
reviewed
Jan 27, 2021
samouri
reviewed
Jan 27, 2021
caroqliu
approved these changes
Jan 28, 2021
dvoytenko
approved these changes
Jan 28, 2021
…ineRect for consistency
zaparent
pushed a commit
to zaparent/amphtml
that referenced
this pull request
Jan 29, 2021
…oject#32243) - 🖍 Previously the video element would lag behind when using `position: fixed` at undock. `position: absolute` follows the video as it scrolls, eliminating the lag. (This was backported from Bento version.) - 🚀 Use existing `clientRect` where possible to prevent `getBoundingClientRect()` calls. - 🚀 Migrates to `IntersectionObserver`. Before / after (at 0.75 speed) https://user-images.githubusercontent.com/254946/106031359-0756a300-6084-11eb-8bab-7cbe1f769313.mp4
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Jan 29, 2021
* 'master' of github.com:ampproject/amphtml: (1020 commits) 🏗 Clean up CI config files (ampproject#32303) 🏗 Remove Browser Installation from CI tasks and use smaller instances when possible (ampproject#32310) Cleanup fie-resources experiment (ampproject#32226) 🏗 Fix bug in build target discovery logic (ampproject#32307) 📖 Update TOC on TESTING.md (ampproject#32304) 🏗 Reorganize browserify caching code (ampproject#32297) Fix <textarea> scrollHeight calculation (ampproject#32292) 📖 Update testing docs (ampproject#32298) Fix missing space and mention `https` (ampproject#32293) ✨ [Story auto-analytics] Added validation and tests (ampproject#32288) 🏗 Consolidate remaining CircleCI VM setup steps into separate scripts (ampproject#32290) 🏗 Cache Karma's babel transforms during CircleCI builds (ampproject#32295) Add validation rules for aspect-ratio support via SSR (ampproject#32262) bump up viewer-messaging version (ampproject#32286) 🖍🚀 Alternate `position: fixed/absolute` when docking/undocking (ampproject#32243) ✨ [Panning media] Transition siblings by ID (ampproject#32217) 📦 Update dependency watchify to v4 (ampproject#32284) 📦 Update dependency rollup to v2.38.1 (ampproject#32274) 🐛♻️ ADS: XHRs race condtion and responsivnes fix (ampproject#32271) Add support for gdpr_conseented_providers, useCCPA_USPAPI, and _fw_us_privacy (ampproject#32275) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖍 Previously the video element would lag behind when using
position: fixedat undock.position: absolutefollows the video as it scrolls, eliminating the lag. (This was backported from Bento version.)🚀 Use existing
clientRectwhere possible to preventgetBoundingClientRect()calls.🚀 Migrates to
IntersectionObserver.Before / after (at 0.75 speed)
dock-fixed-absolute.mp4
(Tip: right click >
Loop)