Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Use aliased paths in generated extensions #34860

Merged
merged 1 commit into from
Jun 15, 2021
Merged

🏗 Use aliased paths in generated extensions #34860

merged 1 commit into from
Jun 15, 2021

Conversation

alanorozco
Copy link
Member

No description provided.

@alanorozco alanorozco requested a review from rcebulko June 15, 2021 15:01
rcebulko
rcebulko approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Didn't realize the linter wouldn't catch this due to the different paths

@alanorozco
Copy link
Member Author

@rcebulko We intentionally exclude the extension templates from linting. But maybe we can lint generated extensions on CI.

@rcebulko
Copy link
Contributor

@rcebulko We intentionally exclude the extension templates from linting. But maybe we can lint generated extensions on CI.

I'm inclined to believe that's barely worth the work, since the templates should change relatively infrequently and the generated code would have to pass CI to get submitted anyway, would get autofixed by IDEs, etc

@alanorozco alanorozco merged commit 1de401f into ampproject:main Jun 15, 2021
@alanorozco alanorozco deleted the make-extension-imports branch June 15, 2021 15:24
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 16, 2021
@westonruter
Merge branch 'main' of github.com:ampproject/amphtml into add/amp-fac…
a7e72f4 
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml: (23 commits)
  `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867)
  🚮 Remove src/purifier.js rollup config (ampproject#34876)
  Validator Rollup (ampproject#34769)
  ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875)
  Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813)
  🏗📖 Fix some example files that do not validate (ampproject#34835)
  🏗Add `#test` and `#testing` to alias list (ampproject#34853)
  Add css files for missing components (ampproject#34861)
  Apply bulk transform to html tags (ampproject#34836)
  🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865)
  ♻️  Extract `applyFillContent` into a standalone function (ampproject#34858)
  Give script tag closing tag (ampproject#34832)
  🏗 Refinements to renovate config (ampproject#34862)
  Bento: Enable `SocialShare` for npm publishing (ampproject#34817)
  🏗 Use aliased paths in generated extensions (ampproject#34860)
  ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834)
  🏗 Set `wrapper` on generated Bento extensions (ampproject#34843)
  🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827)
  🏗 Allow extension bundles to specify their own wrapper (ampproject#34845)
  🏗🚀 Speed up validated example grouping ~45x (ampproject#34837)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanorozco @rcebulko