Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double navigation from page-outlink. #35187

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Prevent double navigation from page-outlink. #35187

merged 1 commit into from
Jul 12, 2021

Conversation

gmajoulet
Copy link
Contributor

Users could swipe up and then click the anchor. We disable this to not trigger side effects like:

  • native environments that intercept navigation events and open two webviews/CCTs
  • potential different analytics triggering in web environment

@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Jul 12, 2021
@amp-owners-bot
Copy link

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page-attachment.js

@gmajoulet gmajoulet merged commit 2418d20 into ampproject:main Jul 12, 2021
wg-stories Sprint automation moved this from In progress to Done Jul 12, 2021
@mszylkowski mszylkowski mentioned this pull request Jul 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmajoulet @processprocess @ampprojectbot