Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [amp story] Replay/next page button bug fix #37316

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

processprocess
Copy link
Contributor

Once the replay class was added, it was not being removed. Both classes were present resulting in always displaying the replay button

Due to async between mutation and setting state the classList was not being updated properly.
This sets the state synchronously within the mutation.

Fixes a regression from #37098

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 7, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/pagination-buttons.js

@processprocess processprocess merged commit 3dd998e into ampproject:main Jan 7, 2022
@processprocess processprocess deleted the replay-button branch January 7, 2022 18:24
westonruter added a commit that referenced this pull request Jan 10, 2022
…nce-attr-to-hero-img

* 'main' of github.com:ampproject/amphtml: (525 commits)
  mathml storybook: supply missing component definition. (#37326)
  storybook: Iframe --> BentoIframe (#37327)
  🖍  [Story system layer] New ad badge (#37311)
  🐛 [amp story] Replay/next page button bug fix (#37316)
  🚀  [Story performance] Remove affiliate links (#37280)
  Compiler: Add amp-carousel-0.1 to the builder map (#37308)
  ⏪  [Story system layer] Audio icon disappears when story has background audio (#37314)
  🚀  [Story performance] Remove story access (#37281)
  Fix remapping esbuild output on Windows (#37312)
  🐛 adds in correct weight for amp-story-product-tag text (#37188)
  typechecking carousel: remove shame files (#37213)
  Use remapping to remap minified sourcemap into source code (#37238)
  SwG Release 0.1.22.199 (#37310)
  🐛 Adds microsoft-edge protocol (#34168)
  Sync for validator cpp engine and cpp htmlparser (#37292)
  ✨ amp-story-shopping Updated currency with product price and correct Localized currency (#37249)
  ✨[Smartadserver ad extension] Implement support for Fast Fetch (#36991)
  Remove client-side-experiments-config.json from this repo (#37304)
  🚮  Remove closure compiler logic from build-system. (#37296)
  🌐 Added RTL ordering i18n for amp story shopping tag (#37252)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants