Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [Story performance] Remove affiliate links #37280

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Dec 29, 2021

Removes the affiliate links which are not used (literally 0 uses). We're launching rich tooltips on the shopping component which have better UX.

dist/v0/amp-story-auto-ads-0.1.mjs: 螖 -0.08KB
dist/v0/amp-story-auto-ads-0.1.js: 螖 -0.04KB
dist/v0/amp-story-0.1.mjs: 螖 -1.24KB
dist/v0/amp-story-1.0.mjs: 螖 -1.24KB
dist/v0/amp-story-0.1.js: 螖 -1.21KB
dist/v0/amp-story-1.0.js: 螖 -1.21KB

@mszylkowski mszylkowski marked this pull request as ready for review January 4, 2022 20:17
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 4, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-affiliate-link.css
extensions/amp-story/1.0/amp-story-affiliate-link.js
extensions/amp-story/1.0/amp-story-embedded-component.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-store-service.js
extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/page-advancement.js
extensions/amp-story/1.0/test/integration/test-amp-story-affiliate-link.js

@mszylkowski mszylkowski self-assigned this Jan 4, 2022
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Jan 4, 2022
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too good, so easy yet so impactful 馃ゲ

@mszylkowski mszylkowski merged commit 7303935 into ampproject:main Jan 7, 2022
wg-stories Sprint automation moved this from In progress to Done Jan 7, 2022
@mszylkowski mszylkowski deleted the removeAffiliateLinks branch January 7, 2022 17:15
westonruter added a commit that referenced this pull request Jan 10, 2022
鈥ce-attr-to-hero-img

* 'main' of github.com:ampproject/amphtml: (525 commits)
  mathml storybook: supply missing component definition. (#37326)
  storybook: Iframe --> BentoIframe (#37327)
  馃枍  [Story system layer] New ad badge (#37311)
  馃悰 [amp story] Replay/next page button bug fix (#37316)
  馃殌  [Story performance] Remove affiliate links (#37280)
  Compiler: Add amp-carousel-0.1 to the builder map (#37308)
  鈴  [Story system layer] Audio icon disappears when story has background audio (#37314)
  馃殌  [Story performance] Remove story access (#37281)
  Fix remapping esbuild output on Windows (#37312)
  馃悰 adds in correct weight for amp-story-product-tag text (#37188)
  typechecking carousel: remove shame files (#37213)
  Use remapping to remap minified sourcemap into source code (#37238)
  SwG Release 0.1.22.199 (#37310)
  馃悰 Adds microsoft-edge protocol (#34168)
  Sync for validator cpp engine and cpp htmlparser (#37292)
  鉁 amp-story-shopping Updated currency with product price and correct Localized currency (#37249)
  鉁╗Smartadserver ad extension] Implement support for Fast Fetch (#36991)
  Remove client-side-experiments-config.json from this repo (#37304)
  馃毊  Remove closure compiler logic from build-system. (#37296)
  馃寪 Added RTL ordering i18n for amp story shopping tag (#37252)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants