-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Migrate Stories 40..44 to args
#37729
Conversation
args
@@ -72,20 +71,15 @@ export const WithUl = () => { | |||
|
|||
WithUl.storyName = 'with <ul>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this. It's used to describe the story in more detail if needed, but in most cases in our storybook tests, it's the same as the test name.
side: { | ||
name: 'side', | ||
defaultValue: 'left', | ||
options: ['left', 'right', undefined], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be undefined
or can be none
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it needs to be undefined
so that the size
attr is not set. Setting size='none'
does not trigger the correct behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can u add this explanation as a comment so its not confusing why undefined
is one of the options.
const backgroundColor = color('background'); | ||
const backdropColor = color('backdrop color'); | ||
|
||
export const _default = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to Default
Partial for #35923.