Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overflow option to be set. #436

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Conversation

officer-rosmarino
Copy link

Now when you declare a queue you can specify the overflow option (eg. "reject-publish"). (documentation)

Usage:
await ch.assertQueue(q, { overflow: 'reject-publish' });

Now when you declare a queue you can specify the overflow option (eg. "reject-publish")
@officer-rosmarino
Copy link
Author

What should I do? I don't understand why checks have failed.

@squaremo
Copy link
Collaborator

I don't understand why checks have failed.

Me neither. Looks like a problem with npm. I've restarted the TravisCI build. If it keeps having problems, I'll have to do some investigation.

@officer-rosmarino
Copy link
Author

@squaremo After you restart. should I do anything?

@squaremo
Copy link
Collaborator

squaremo commented Jul 2, 2018

OK, one problem is with Node.JS 9.x, for small values of x, apparently: nodejs/node#16781. I think I can just alter the version of Node.JS that's tested to a later one, to avoid it.

The other problem is genuinely in amqplib, just mysterious (and not your fault). It's a race in the muxing code that used to very rarely cause test flakes; now it seems to deterministically cause test flakes.

@squaremo
Copy link
Collaborator

squaremo commented Jul 3, 2018

OK, it may take me a while to fix those CI failures. If you remove the spurious whitespace changes, I'll merge this.

@officer-rosmarino
Copy link
Author

officer-rosmarino commented Jul 3, 2018

@squaremo pardon my ignorance but this is the first time I do a (very small) contribution on Github. But i need to start somewhere 😄
Do i need to delete the Pull Request, fix it, and do it again, or is there some other way?

@kibertoad
Copy link
Collaborator

@honestserpent If you push commit to the same branch you created PR in, PR will get updated automatically.

@officer-rosmarino
Copy link
Author

@kibertoad thank you.
@squaremo just done.

Copy link
Collaborator

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@squaremo squaremo merged commit f1ca76d into amqp-node:master Jul 4, 2018
@squaremo
Copy link
Collaborator

squaremo commented Jul 4, 2018

this is the first time I do a (very small) contribution on Github

@honestserpent Cool! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants