-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overflow option to be set. #436
Conversation
Now when you declare a queue you can specify the overflow option (eg. "reject-publish")
What should I do? I don't understand why checks have failed. |
Me neither. Looks like a problem with npm. I've restarted the TravisCI build. If it keeps having problems, I'll have to do some investigation. |
@squaremo After you restart. should I do anything? |
OK, one problem is with Node.JS 9.x, for small values of x, apparently: nodejs/node#16781. I think I can just alter the version of Node.JS that's tested to a later one, to avoid it. The other problem is genuinely in amqplib, just mysterious (and not your fault). It's a race in the muxing code that used to very rarely cause test flakes; now it seems to deterministically cause test flakes. |
OK, it may take me a while to fix those CI failures. If you remove the spurious whitespace changes, I'll merge this. |
@squaremo pardon my ignorance but this is the first time I do a (very small) contribution on Github. But i need to start somewhere 😄 |
@honestserpent If you push commit to the same branch you created PR in, PR will get updated automatically. |
@kibertoad thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@honestserpent Cool! 🎉 |
Now when you declare a queue you can specify the overflow option (eg. "reject-publish"). (documentation)
Usage:
await ch.assertQueue(q, { overflow: 'reject-publish' });