-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting "Too many HTTP redirects" when attempting to file radars #89
Comments
I don't have the time to do a full PR, but running this in debug mode brings up this:
Likely this is the change |
It looks like at this state the entire
|
I'm getting this also. |
Digging in a bit further, now I'm back in NYC, this is the new re-direction path ( had to write a quick app ) - will see about wrapping this up and making a PR
|
Thanks for looking into this! Gotta love open source! Also note this comment that hints on a undocumented radar JavaScript API that might be less fragile: |
After some digging around I managed to get the app running again. By deleting some code. Specifically I removed the code that manually sets the Host field:
Doing that messes up the redirect we get after sending our authentication data, directing us to I noticed this by comparing the reqests Safari and QuickRadar make during login. Safari / request:
Safari / respnse:
QuickRadar / request:
QuickRadar / response:
Notice the difference for I don't know the background here - why this has been done in the first place. But simply deleting those lines seems to do the trick for me. I can open up a PR for that, unless someone has a better idea. |
If it works, I say go for it! Most of the stuff QuickRadar sends just came from me observing a lot of sessions in Charles, and trying adding things until it worked. So this is exactly in keeping with the way the app has been built :) Amy
|
Fixes the “Too many HTTP redirects” issue during login. See amyworrall#89 (comment) for details.
Is there any ETA on when a new build will be released? |
I'm building from master using #90 and still seeing these errors. One thing I have noticed is that the errors occur after I submit my first Radar (e.g. first one works fine, but subsequent ones do not.) Maybe there's something getting cached in the URL connection? |
@chockenberry confirmed: success the first time, "too many HTTP redirects" the second time. |
@amyworrall Sounds like this issue should be reopened. I'm wondering if @steipete and @matej are seeing the same "works the first time, not the second" behavior. |
I'm so sorry that I haven't had any time to look at this yet. I'm a bit swamped at the moment (plus my country is imploding politically, which is distracting). Thanks to everyone who is helping! Sent from my iPhone
|
True. Noticed this as well today. This works once but then it's trouble again... probably won't be as easy to fix than just deleting a line. But it went from not working at all to at least somewhat working :) |
Looks like that's their way to rate limit you guys. ;) The requests do differ between the first and second attempt. One thing I noticed is that the authenticate action on the login page no longer has the session ID the second time around. This leads to a different authenticate URL being invoked and things go south from there on. There is probably no need to even login at this point (the session could be reused). But since that would require even more and special casing, I just decided to purge cookies before we start. That should make every request equal to the first one. Seems to work. Just deleting the "myacinfo" cookie appears to be enough, so this could be limited a bit, if anyone has any good arguments on why we should keep the remaining ones. |
I'm assuming they made changes at WWDC 2016? Reproduced on two machines with two different developer accounts. It happens on the "Signing in to RadarWeb" step.
The text was updated successfully, but these errors were encountered: