-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values of number zero are always filtered if filter is set #406
Comments
Good catch! You are right, we had an issue with that outside of the filters because of a conditional like that. |
Hi @dbanksdesign! |
Sorry about that @arielwb! It should be published now in v2.10.1! |
dbanksdesign
pushed a commit
that referenced
this issue
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
For a token defined with value zero, for example
opacity: {value: 0}
, and anyfilter
function set in config it appears that token is always filtered out.I believe the cause is https://github.com/amzn/style-dictionary/blob/master/lib/filterProperties.js#L37, which perhaps should be
} else if (typeof value.value !== 'undefined') {
This line only kicks in if a filter is set in config, as the entire filtering check is bypassed with no filter config.
Thoughts?
The text was updated successfully, but these errors were encountered: