fixed typo #690
Merged
fixed typo #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazzmoney
approved these changes
Aug 31, 2021
dbanksdesign
requested changes
Sep 2, 2021
There was a problem hiding this comment.
Thanks for catching this! This file is actually being generated from JSDoc, so if you could update the JSDoc comment here: https://github.com/amzn/style-dictionary/blob/main/lib/common/formats.js#L644 first and then run npm run generate-docs that should make sure this change doesn't get thrown out when we generate the docs in the future. Thanks!
|
Hey @dbanksdesign I changed it according to your comment, hope this is correct. Cheers |
|
Just so I know, @dbanksdesign you need no changes from my side, correct? This will just be merged at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.