Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Change the
FileHeader
'sdefaultMessage
input typestring[]
instead of juststring
.Reason:
File Header's defaultMessage is defined as an array in code.
File Header in Examples shows expanding the
defaultMessage
. E.g.return [...defaultMessage, 'hello world']
. TypeScript won't allow this currently due to thestring
data type.Altho the current data type works, it implicitly converts the array into a string which results in a malformed header.
vs (fixed)
P.S. Is there a way to change the header for every file without the need to specify the custom header formater in every file/platform? Currently, I do following:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.