feat: any swift format #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypt096
approved these changes
Nov 20, 2021
crypt096
approved these changes
Nov 23, 2021
dbanksdesign
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Overall this looks great! Just a few comments and we can get this merged in. If you are ok with it, when we merge this in we would also like to give credit to @antoniogamizbadger because they started a similar PR as well.
|
@gabischima Would love to get this one merged next week. Any chance you could make the requested changes? Thanks! |
yes ! (: i will go into that |
yes of course ! |
chazzmoney
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: could help #719
Description of changes:
ios-swift/any.swiftwith:objectType: type for the swift object - default is classimport: array or string to import modules - default is ["UIKit"]accessControl: access level for the object - default is publicios-swift/classandios-swift/enumto importany.swifttemplatesetSwiftFilePropertiesto format file object for swiftsetSwiftFilePropertiesand snapshot for swift templateios-swiftformatsios-swift/any.swiftto examples / basic / config.jsonBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.