SPI Engine: improve test_sleep_delay #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for sleep delay being affected by SPI word size (should not be affected) Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
12 tasks
Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
gastmaier
requested changes
Jun 26, 2024
| @@ -281,7 +296,7 @@ task sleep_delay_test( | |||
| // Write commands | |||
| axi_write (`SPI_ENGINE_SPI_REGMAP_BA + GetAddrs(AXI_SPI_ENGINE_CMD_FIFO), `INST_CFG); | |||
| axi_write (`SPI_ENGINE_SPI_REGMAP_BA + GetAddrs(AXI_SPI_ENGINE_CMD_FIFO), `INST_PRESCALE); | |||
| axi_write (`SPI_ENGINE_SPI_REGMAP_BA + GetAddrs(AXI_SPI_ENGINE_CMD_FIFO), `INST_DLENGTH); | |||
| axi_write (`SPI_ENGINE_SPI_REGMAP_BA + GetAddrs(AXI_SPI_ENGINE_CMD_FIFO), ((`INST_DLENGTH) & 32'hFFFF_FF00) | 16); | |||
There was a problem hiding this comment.
The situation of this line:
Masking INST_DLENGHT set on common/sv/spi_engine_instr_pkg.sv because it has a default value: DATA_DLENGTH.
DATA_DLENGTH is set on the cfg filespi_engine/cfgs/cfg_inv_cs.tcl e.g, spi_engine/cfgs/cfg_inv_cs.tcl
Wouldn't it be better to be a macro call, e.g. `INST_DLENGTH(`DATA_DLENGTH), `INST_DLENGTH(16)
Only spi_engine currently uses spi_engine_instr_pkg.sv
Same for any instruction that take a value, CLOCK_DIVIDER->INST_PRESCALE etc
| @@ -50,7 +50,7 @@ import test_harness_env_pkg::*; | |||
| //--------------------------------------------------------------------------- | |||
| // SPI Engine configuration parameters | |||
| //--------------------------------------------------------------------------- | |||
| localparam PCORE_VERSION = 32'h0001_0200; | |||
| localparam PCORE_VERSION = 32'h0001_0201; | |||
There was a problem hiding this comment.
Why not take this value from common/sv/adi_regmap_spi_engine_pkg.sv and avoid having to update test on version bump ?
gastmaier
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for sleep delay being affected by SPI word size (should not be affected). Complements analogdevicesinc/hdl#1361