Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-analog): pin @nrwl/vite package to 15.3.x #187

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router

What is the current behavior?

Nx 15.4.x introduced a change that requires a project.json. This pins the Vite plugin to Nx 15.3.x to get the template app working again

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Nx 15.4.x introduced a change that requires a project.json
@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit d371c2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63adb2d7ee114700084e66a9
😎 Deploy Preview https://deploy-preview-187--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit d371c2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63adb2d7210e420009b9be1c
😎 Deploy Preview https://deploy-preview-187--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts brandonroberts merged commit 443038c into main Dec 29, 2022
@brandonroberts brandonroberts deleted the fix-nx-vite-15-3 branch December 29, 2022 15:44
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant