Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): provide slug based on filename #248

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

d-koppenhagen
Copy link
Contributor

closes #247

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Issue Number: #247

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 53b10c8
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63e4518683784d00084d0f09
😎 Deploy Preview https://deploy-preview-248--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 53b10c8
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63e451861ee40d0008149b17
😎 Deploy Preview https://deploy-preview-248--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 53b10c8
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/63e451861d589f00085a8338
😎 Deploy Preview https://deploy-preview-248--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandonroberts
Copy link
Member

@d-koppenhagen there's a build failure happening, will you take a look?

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit bf8581a into analogjs:main Feb 9, 2023
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @d-koppenhagen for code

@allcontributors
Copy link
Contributor

@brandonroberts

I've put up a pull request to add @d-koppenhagen! 🎉

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add slug based on filename to ContentFile data
2 participants