feat(content): add customFilename param to injectContent #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
choyiny
force-pushed
the
inject-content-custom-filename
branch
from
20e5752
to
edf92c0
Compare
choyiny
changed the title
choyiny
force-pushed
the
inject-content-custom-filename
branch
from
d397a84
to
beb8766
Compare
choyiny
force-pushed
the
inject-content-custom-filename
branch
from
beb8766
to
4d5f611
Compare
brandonroberts
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Which package are you modifying?
What is the current behavior?
Closes #595
What is the new behavior?
injectContent now supports a new argument { customFilename: string } that allows a hardcoded md file to be loaded from
/src/content.Example usage
Does this PR introduce a breaking change?
Previously, if
injectContentwas used but a slug is not present, it will default to usenull.md. Now, not providing a slug will throw an Error. Although breaking, this does not seem like intended behavior anyways.Other information
[optional] What gif best describes this PR or how it makes you feel?