Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite-plugin-angular): add support for css preprocessing in component styles #88

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Sep 22, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Previously if a component used scss in the Component styles/styleUrls, it would get directly inlined during Angular compilation without being compiled into CSS. This PR adds support for CSS preprocessing using styleUrls and styles in the Component decorator metadata.

Closes #82

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog

What is the current behavior?

Issue Number: #82

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts brandonroberts merged commit 418c52e into main Sep 22, 2022
@brandonroberts brandonroberts deleted the feat-component-styles branch September 22, 2022 13:10
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component level scss processing
1 participant