Migrate csv capabilities to separate package #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
|
As it stands now, fuzz tests pass when comparing results to the stdlib with LazyQuotes enabled, but the memory performance gains are now slight, and CPU performance is down quote a lot. I wonder if there are better options here (I think the use of |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
internal/csv/detect.go
Outdated
| sw.end += n | ||
|
|
||
| // Process the combined buffer | ||
| i := sw.start |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
This was referenced Jul 17, 2024
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
| sw.end += n | ||
|
|
||
| // process the combined buffer | ||
| i := sw.start |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to open the upstream PR against a feature branch in this repo not the main branch, leading to me making PRs here 🤦 (want to see passing CI instead of pushing to main).