Decode socket data for python3 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Finalized data decoding cases for py3 - Treated cases where luminosity is increased when state is off and when luminosity is set to 0 but state is on
|
Thanks for your contributions! Let me review these later this week and merge! |
|
Would it be possible to also release a new version of the library on pypi? |
|
Let me do that tonight. |
|
@olimpiurob made it version 1.0.3 |
|
The library is now beeing used by the osram lightify light component in the Home Assistant home automation platform. The component has been added in Home Assistant version 0.21 and it is using lightify v1.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.