add locale support for unparse using a formatter #77
Conversation
|
|
||
| LocalizedFormatter | ||
| (unparse [{:keys [format-str formatters date-time-symbols] :as fmt} dt] | ||
| (with-redefs [i/months (.-MONTHS date-time-symbols) |
There was a problem hiding this comment.
Is there a way you can think of to do this without using re-binding vars?
I'm not keen on adding code containing with-redefs to library code.
| @@ -233,7 +255,7 @@ | |||
| :let [d (try (parse-local-date f s) (catch js/Error _ nil))] | |||
| :when d] d)))) | |||
|
|
|||
| (defn unparse | |||
| (defn do-unparse | |||
There was a problem hiding this comment.
I'd prefer to keep this function as part of the API, and perhaps defer to the protocol implementation for say -unparse. That's how clojurescript core does this kind of thing... it's a bit more flexible that way.
| lfmt-month (with-locale fmt-month goog.i18n.DateTimeSymbols_fr)] | ||
| (is (= "quinta-feira, 11 de março de 2010" (unparse lfmt (local-date 2010 3 11)))) | ||
| (is (= "lundi 11 février 2013" (unparse lfmt-month (local-date 2013 2 11)))))) | ||
|
|
|
Hey, Thanks very much for this. I've a couple comments above. Mainly about the use of |
|
See #85 for a fuller implementation. |
I developed support for localized formatter using the with-locale function.