addressing issue #92 #93
Conversation
…nt the same date, but which have different internal times are incorrectly compared
…use the actual year, day-of-year parts
src/cljs_time/extend.cljs
Outdated
| @@ -23,20 +24,13 @@ | |||
| IEquiv | |||
| (-equiv [o other] | |||
| (and (instance? goog.date.Date other) | |||
| (.equals o other))) | |||
| (ct/equal? o other))) | |||
There was a problem hiding this comment.
I'm not sure of the reason for this change. Is it necessary?
There was a problem hiding this comment.
felt like it's better to lean on the cljs-time library to check for equality rather than the underlying goog.date lib ... for example if cljs-time changed to use some other way to check for equality, then this would remain consistent with that. Not religious about it tho...
There was a problem hiding this comment.
Ok, I see the point.
But I'd rather not change it for the sake of it. Could we leave this out, and revisit if it becomes an issue?
src/cljs_time/extend.cljs
Outdated
| @@ -11,7 +11,8 @@ | |||
| (:import | |||
| [goog.date Date] | |||
| [goog.date DateTime] | |||
| [goog.date UtcDateTime])) | |||
| [goog.date UtcDateTime]) | |||
| (:require [cljs-time.core :as ct])) | |||
There was a problem hiding this comment.
I think all (or most) parts of the lib are using the alias time
[cljs-time.core :as time]Could you change it for consistency?
|
Merged, thanks very much for this 👍 |
addressing issue #92