Fix coreaudio module not detecting changes of the default audio device. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgutman
reviewed
Dec 27, 2020
src/coreaudio.c
Outdated
| @@ -139,12 +139,15 @@ static void destroy_ca(struct SoundIoPrivate *si) { | |||
| struct SoundIoCoreAudio *sica = &si->backend_data.coreaudio; | |||
|
|
|||
| AudioObjectPropertyAddress prop_address = { | |||
| kAudioHardwarePropertyDevices, | |||
| kAudioHardwarePropertyDefaultOutputDevice, | |||
There was a problem hiding this comment.
I think we shouldn't replace kAudioHardwarePropertyDevices, because that will stop us from rescanning if an audio device is added which does not change the default input or output device.
Just adding listeners for kAudioHardwarePropertyDefaultOutputDevice and kAudioHardwarePropertyDefaultInputDevice should work, right?
There was a problem hiding this comment.
You are right. Changed my PR.
alex-the-man
force-pushed
the
fix-core-audio-default-device-change
branch
from
b4a09e8
to
f3bb0d0
Compare
cgutman
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.