Numeric to float #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrglo
reviewed
Aug 29, 2017
| if (property.decimals && property.decimals > 0) { | ||
| column = 'NUMERIC(' + property.maxLength + ',' + property.decimals + ')'; | ||
| } else { | ||
| column = integerType; |
There was a problem hiding this comment.
For compatibility a else if is required here:
if (property.decimals && property.decimals > 0) {
column = 'NUMERIC(' + property.maxLength + ',' + property.decimals + ')';
} else if (property.maxLength > 0) {
column = integerType;
} else {
column = floatType;
}
andrglo
reviewed
Aug 29, 2017
src/index.js
Outdated
| break; | ||
| case 'real': | ||
| case 'double precision': | ||
| property.type = 'numeric'; |
There was a problem hiding this comment.
property.type should contain a valid json schema type then this line better be property.type = 'number'
|
This does have the effect of eviscerating the maxLength property. Would it
be better to make it a varchar in this case? In jsonschema numbers can
have min and max values but length is somewhat meaningless? Or, if this is
for compatibility with existing code, I'm comfortable with just mapping to
an integer type as you suggested.
…On Tue, Aug 29, 2017 at 6:44 PM, Andre Gloria ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/index.js
<#4 (comment)>
:
> @@ -535,7 +537,7 @@ function propertyToPostgres(property, name, schema, isAlter) {
if (property.decimals && property.decimals > 0) {
column = 'NUMERIC(' + property.maxLength + ',' + property.decimals + ')';
} else {
- column = integerType;
For compatibility a else if is required here:
if (property.decimals && property.decimals > 0) {
column = 'NUMERIC(' + property.maxLength + ',' + property.decimals + ')';
} else if (property.maxLength > 0) {
column = integerType;
} else {
column = floatType;
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmhfwIrWmGerK-kH8YwgO_8jQPcochvks5sdJQygaJpZM4PFS7X>
.
--
RICHARD DOWNE
Figure 1 Director of Data
WEBSITE <https://figure1.com> | TWITTER <http://twitter.com/figure1> |
FACEBOOK <https://www.facebook.com/figure1>
|
|
Yes, only for compatibility with existing code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that jsonschema has both "numeric" and "integer" types, I think that numeric types with no fixed point specifications should be floating point types in the database.
Happy to flesh this out to mysql as well; did postgres here because that's the db I know and the one I work with.