-
Notifications
You must be signed in to change notification settings - Fork 97
Implement back in sample detail top bar #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant overhaul of the Android AI Sample Catalog's user interface and underlying architecture. The primary goal is to enhance the sample detail top bar and standardize UI components across the application. This is achieved by extracting common UI elements into a new ui-component
module, enabling a consistent and modern design system. Furthermore, two new AI samples, gemini-image-chat
and gemini-video-metadata-creation
, have been added, showcasing advanced Gemini model capabilities. Existing samples have been updated to leverage the new UI components and the latest Gemini Flash models, improving their visual appeal and functionality.
Highlights
- New UI Component Module: A dedicated module (
ui-component
) has been created to house reusable UI elements such as buttons, text inputs, dropdowns, and theming. This promotes consistency and simplifies future UI development across all samples. - Enhanced Sample Detail UI: The top bar and card layouts for displaying individual AI samples have been completely redesigned, offering a more modern and informative user experience. This includes new "wide" and "row" card types and a dynamic top app bar.
- Introduction of New AI Samples: Two new samples, "Gemini Image Chat" and "Gemini Video Metadata Creation," have been integrated. These demonstrate multimodal capabilities (text + image input/output) and advanced video analysis (generating descriptions, chapters, hashtags, etc.) using the latest Gemini Flash models.
- Updated Gemini Model Integration: Existing samples (Chatbot, Multimodal, Video Summarization) have been upgraded to utilize the newer "Gemini Flash" models, and the Chatbot specifically now uses "gemini-2.5-flash".
- Refactored Sample Codebases: Several existing samples (Chatbot, Multimodal, Video Summarization, Image Description, Writing Assistance, Imagen, Magic Selfie, Live Todo) have undergone significant refactoring to adopt the new
ui-component
module, streamline their UI logic, and improve error handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request consistently implements the back button functionality across numerous sample screens by leveraging LocalOnBackPressedDispatcherOwner
. The changes are correct and functional. However, this approach has introduced a bit of repetitive code in each screen. My review includes a suggestion to refactor SampleDetailTopAppBar
to encapsulate the back navigation logic. This would provide a default behavior, reducing boilerplate code in all consumer screens and centralizing the logic. Applying this suggestion would allow for cleanup across all the modified sample screens.
Implement back in sample detail top bar