Skip to content

Conversation

lethargicpanda
Copy link
Collaborator

@lethargicpanda lethargicpanda commented Sep 11, 2025

Screenshot_20250911_111004 Screenshot_20250911_110955

Copy link

google-cla bot commented Sep 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lethargicpanda lethargicpanda changed the title Add collapsable top bar Add collapsable appbar to sample list Sep 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @lethargicpanda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the AI Sample Catalog application by introducing a modern, collapsable top bar and centralizing common UI components into a dedicated module. It expands the catalog with two new advanced AI samples and refactors existing ones to align with the new UI and leverage the latest Gemini models, resulting in a more cohesive and feature-rich application.

Highlights

  • New Collapsable Top Bar UI: Introduced a new collapsable top bar for the main application screen, enhancing the user experience with dynamic title display and improved aesthetics.
  • New UI Component Module: A new :ui-component module has been added to centralize reusable UI elements such as buttons, text inputs, dropdowns, and theme definitions, promoting consistency and reususability across samples.
  • New AI Samples Added: Two new AI samples, gemini-image-chat and gemini-video-metadata-creation, have been integrated into the catalog, showcasing advanced Gemini model capabilities.
  • Existing Samples Refactored: Several existing samples (gemini-chatbot, gemini-live-todo, gemini-multimodal, genai-image-description, genai-summarization, genai-writing-assistance, imagen, magic-selfie, gemini-video-summarization) have been refactored to utilize the new shared UI components and updated Gemini models (e.g., Gemini 2.5 Flash), improving their consistency and leveraging the latest model versions.
  • Dependency and Build System Updates: The Firebase BOM and Media3 versions have been updated, and new libraries for ML Kit Segmentation, Compose UI Text Google Fonts, and ExifInterface have been added, ensuring the project uses up-to-date dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lethargicpanda lethargicpanda changed the base branch from main to redesign September 11, 2025 00:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major redesign of the sample catalog's main screen, featuring a new collapsible app bar and updated card layouts for a more modern look and feel. It also adds two new samples, "Gemini Image Chat" and "Gemini Video Metadata Creation," showcasing advanced AI capabilities. A significant part of this effort involved refactoring common UI elements into a new :ui-component module, which greatly improves code reusability and consistency across the different samples. The existing samples have been updated to use these new components, resulting in a more unified user experience. The overall changes are excellent and substantially improve the project's structure and presentation. My review includes a few suggestions for further refinement, mainly around adhering to the project's style guide and improving maintainability by avoiding hardcoded values.

@lethargicpanda
Copy link
Collaborator Author

cc @JolandaVerhoef

@lethargicpanda lethargicpanda merged commit b2857e4 into redesign Sep 12, 2025
1 check passed
@ksemenova
Copy link
Collaborator

It looks like there is an extra space on top, would be great to remove it and make the animation more smooth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants