Imagen Editing sample redesign

[lethargicpanda]

Redesign of the Imagen Editing sample

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @lethargicpanda, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a comprehensive redesign and architectural refactoring of the AI Sample Catalog application. The core objective is to enhance UI consistency and streamline development by extracting and centralizing shared UI components and theming into a dedicated ui-component module. This effort not only modernizes the visual presentation of the main sample catalog and individual sample screens but also establishes a more maintainable and scalable foundation for future development.

Highlights

• UI Component Centralization: A new ui-component module has been introduced to centralize common UI elements, such as buttons, text inputs, message bubbles, and video players, which were previously duplicated across various sample applications.
• Theming Refactoring: The application's theming (colors and typography) has been refactored into the new ui-component module, ensuring a consistent look and feel across all samples and simplifying future theme management.
• Sample Catalog Redesign: The main sample catalog screen has been visually redesigned, incorporating new CatalogWideCard and CatalogRowCard components to display samples more effectively, including support for featured samples and key art.
• Sample UI Modernization: Numerous individual AI samples have been updated to utilize the new shared UI components and theming, leading to a more cohesive and modern user experience throughout the application.
• Dependency Updates: Key dependencies, including Material3 and ML Kit Segmentation, have been updated to their latest versions, and new libraries for rich text rendering and window size classes have been integrated.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant redesign of the Imagen Editing sample, aligning it with a more modern UI by leveraging shared UI components. The changes improve the visual presentation and structure of the code. However, the redesign has introduced a few regressions in user experience, such as removing the ability to re-enter the mask editor and incorrect back-handling behavior. My review includes suggestions to address these issues, fix a style guide violation, and make other minor improvements.

[lethargicpanda]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a great step forward in modernizing the Imagen Editing sample, refactoring the UI into a more streamlined, single-screen experience using shared components. The overall redesign is well-executed. However, there are a couple of regressions in user experience that should be addressed. Specifically, handling for the system back button during mask editing has been lost, and canceling the masking process now incorrectly resets the entire screen, causing the user to lose their generated image. I've also pointed out some minor UX improvements related to image scaling and control states.