[Jetsurvey] fixed app crash on changing date selection #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
requested changes
May 12, 2021
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyFragment.kt
Outdated
Show resolved
Hide resolved
Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyViewModel.kt
Outdated
Show resolved
Hide resolved
| import com.example.compose.jetsurvey.theme.JetsurveyTheme | ||
| import com.google.android.material.datepicker.MaterialDatePicker | ||
| import java.text.SimpleDateFormat | ||
| import java.util.Date |
There was a problem hiding this comment.
these imports are no longer needed.
make sure you run spottlessApply
florina-muntenescu
requested changes
May 14, 2021
| fun onDatePicked(questionId: Int, date: String) { | ||
| updateStateWithActionResult(questionId, SurveyActionResult.Date(date)) | ||
| fun onDatePicked(questionId: Int, pickerSelection :Long?) { | ||
| val selectedData = Date().apply { |
There was a problem hiding this comment.
typo - selectedDate
made date format pattern as a const.
Abhimanyu14
force-pushed
the
abhimanyu/jetsurvey-issue-512
branch
from
cfadddd to
b79e679
Compare
|
@florina-muntenescu , |
florina-muntenescu
approved these changes
Jul 13, 2021
|
I missed this. Thank you @Abhimanyu14 for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the app crash on changing the selected date for the date selection question.
Issue link: #512